fix(cli): fix flaky tests#9560
Closed
alex-alecu wants to merge 20 commits intomainfrom
Closed
Conversation
alex-alecu
changed the title
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by gpt-5.4-2026-03-05 · 1,615,673 tokens |
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)None. Files Reviewed (4 files)
Reviewed by gpt-5.4-2026-03-05 · 950,378 tokens |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.5-2026-04-23 · 3,592,526 tokens |
Contributor
Author
|
Closing in favor of a clean replacement PR that starts from origin/main and contains only the upstream provider-test fixture fix from anomalyco/opencode#24416 (plus Kilo-required package/annotation adaptation). Fixed here #9600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes the provider plugin test by mirroring upstream OpenCode's fixture fix instead of changing plugin initialization behavior.
This ports the approach from anomalyco/opencode#24416: mark the project and global plugin config directories as dependency-ready so the provider persistence test exercises plugin/provider state rather than waiting on real npm install timing. Kilo writes
@kilocode/pluginin that fixture because our config dependency package name differs from upstream's@opencode-ai/plugin.This was not already present from recent upstream-related merges because those updates did not include OpenCode commit
179e540ccb556fc48934a5a34bbd0920c8af87b4from anomalyco/opencode#24416. That upstream fix merged on Apr 26 after the provider/test code we had synced or cherry-picked, so Kilo still had the older test fixture and reproduced the CI timeout until this PR ported the small targeted change.The final runtime diff avoids
packages/opencode/src/plugin/index.ts; the remaining implementation changes are the upstream-aligned provider test fixture plus a small Windows flock release retry for transient lock-directory deletion failures seen in CI.